-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add submodule version+data hash info to --version --debug output #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cargo.toml
Outdated
| chrono = { version = "0.4", features = ["serde"] } | ||
| uuid = { version = "1.8", features = ["v4"] } | ||
| sha2 = "0.10" | ||
| sha2 = "0.10.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is causing the OpenSSL build issue. We use rustls-tls in the reqwest dependency to work around a similar issue. I wonder if using use https://docs.rs/aws-lc-rs/1.15.2/aws_lc_rs/digest/fn.digest.html here would resolve the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like aws-lc-rs also failed the build for the same reason 💀
i resolved the build failure by adding the following to Cargo.toml depencies:
openssl = { version = "0.10", features = ["vendored"] }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By how much does that increase the binary size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's a better solution, but if the size increase is significant, we should look into it more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh lol the binary just stays the same size:
[current release]
hbwei@6c7e67c57386 iam-policy-autopilot-awslabs % du -sh ./target/release/iam-policy-autopilot
53M ./target/release/iam-policy-autopilot
[this PR changes]
hbwei@6c7e67c57386 iam-policy-autopilot % du -sh target/release/iam-policy-autopilot
52M target/release/iam-policy-autopilot
maybe it's because I just added openssl to the workspace dependencies, which don't get packaged into the binary
|
The PR title will need a |
…mments to structs in build.rs
don't forget about this |
feedback has been addressed, thanks!
… policy-generation; other refactors
iam-policy-autopilot-policy-generation/src/shared_submodule_model.rs
Outdated
Show resolved
Hide resolved
iam-policy-autopilot-policy-generation/src/shared_submodule_model.rs
Outdated
Show resolved
Hide resolved
mschlaipfer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Issue #, if available:
#82
Description of changes:
added custom
--versionoutput to publish boto3, botocore git tag+commit+data hash (data hash is the hash of the simplified data files). This information will only be exposed if the hidden--debugflag is set; current --version behaviour without the--deubgflag will remain unchanged.example output
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.